xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: a couple getbmap cleanups

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: [PATCH 1/2] xfs: a couple getbmap cleanups
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 9 Apr 2009 13:11:35 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <9EF64CF3-FDFC-4777-94A5-7295E827ABA4@xxxxxxx>
References: <20090224133858.GB15820@xxxxxxxxxxxxx> <9EF64CF3-FDFC-4777-94A5-7295E827ABA4@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Apr 06, 2009 at 07:57:48PM -0500, Felix Blyakher wrote:
> Shouldn't we set error to ENOMEM here?

Yes, good catch.

> Should the callers be taught to handle ENOMEM now?

The kernel callchain handles it, and in userspace the only caller
(xfs_io) will handled it by printing an out of memory message.

<Prev in Thread] Current Thread [Next in Thread>