Re: [PATCH 4/6] xfs: use memdup

xfs

Re: [PATCH 4/6] xfs: use memdup_user()

To:	Roland Dreier <rdreier@xxxxxxxxx>
Subject:	Re: [PATCH 4/6] xfs: use memdup_user()
From:	Li Zefan <lizf@xxxxxxxxxxxxxx>
Date:	Thu, 09 Apr 2009 08:43:33 +0800
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, felixb@xxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<adabpr76oia.fsf@xxxxxxxxx>
References:	<49DC4CC0.9050805@xxxxxxxxxxxxxx> <49DC4D54.3020001@xxxxxxxxxxxxxx> <20090408132254.GA5957@xxxxxxxxxxxxx> <adabpr76oia.fsf@xxxxxxxxx>
User-agent:	Thunderbird 2.0.0.9 (X11/20071115)

Roland Dreier wrote:
>  > wouldn't NULL be a better error return for this kind of interface,
>  > matching kmalloc?
> 
> I guess returning an error code from memdup_user() lets callers
> distinguish between ENOMEM and EFAULT.  Not sure if that's important or
> not but there probably are at least some sites that care.
> 

Right, and this API is simlilar to strndup_user().

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 4/6] xfs: use memdup_user(), Li Zefan Re: [PATCH 4/6] xfs: use memdup_user(), Christoph Hellwig Re: [PATCH 4/6] xfs: use memdup_user(), Roland Dreier Re: [PATCH 4/6] xfs: use memdup_user(), Li Zefan <= Re: [PATCH 4/6] xfs: use memdup_user(), Felix Blyakher

Previous by Date:	Re: [PATCH 4/6] xfs: use memdup_user(), Felix Blyakher
Next by Date:	Re: [BUG] spinlock lockup on CPU#0, Vegard Nossum
Previous by Thread:	Re: [PATCH 4/6] xfs: use memdup_user(), Roland Dreier
Next by Thread:	Re: [PATCH 4/6] xfs: use memdup_user(), Felix Blyakher
Indexes:	[Date] [Thread] [Top] [All Lists]