xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests: make the mode consistent for all the test scri

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: make the mode consistent for all the test scripts
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Wed, 1 Apr 2009 10:35:22 -0400
Cc: "Josef 'Jeff' Sipek" <jsipek@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20090401070823.GA3044@xxxxxxxxxxxxx>
References: <1238536234-26969-1-git-send-email-jsipek@xxxxxxxxxxxxxx> <1238536234-26969-2-git-send-email-jsipek@xxxxxxxxxxxxxx> <20090401070823.GA3044@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Apr 01, 2009 at 03:08:23AM -0400, Christoph Hellwig wrote:
> A consistant mode sounds fine to me, but we'd have to pull this in as
> git-pull not as patch, right?

Depends on how you manage xfs-dev.git.  patch(1) won't work, but git-apply
will. Personally, I use guilt [1], which let's me push/pop patches much
like quilt, but since it uses git-apply, it works with all the fancy things
git diffs offer.

> Also for some reason some modes seem to change when actually running
> xfstests which makes git barf when pulling into such a tree again, not
> sure where that comes from.

Hrm, I haven't seen this yet.

Josef 'Jeff' Sipek.

[1] http://git.kernel.org/?p=linux/kernel/git/jsipek/guilt.git;a=summary

-- 
The obvious mathematical breakthrough would be development of an easy way to
factor large prime numbers.
                - Bill Gates, The Road Ahead, pg. 265

<Prev in Thread] Current Thread [Next in Thread>