[Top] [All Lists]

Mystery solved? files not written for days...

To: xfs mailing list <xfs@xxxxxxxxxxx>
Subject: Mystery solved? files not written for days...
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 30 Mar 2009 17:01:04 -0500
User-agent: Thunderbird (X11/20090105)

[PATCH] writeback: guard against jiffies wraparound on
inode->dirtied_when checks

When a file is continually dirtied, the check in sync_sb_inodes:

        /* Was this inode dirtied after sync_sb_inodes was called? */
        if (time_after(inode->dirtied_when, start))

may have large windows where this trips on the first
(continually-dirtied) inode on the list when the time_after check has
wrapped, causing the nothing to be written out for that superblock,
potentially for days.

Could this be the reason for those various "hey, my file disappeared
after a crash and I hadn't written to it for *days*" reports we got now
and then, leaving us all scratching our heads?


<Prev in Thread] Current Thread [Next in Thread>