xfs
[Top] [All Lists]

Re: tarballs generated by Makepkgs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: tarballs generated by Makepkgs
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 22 Mar 2009 14:22:08 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090224184252.GA28007@xxxxxxxxxxxxx>
References: <20090215202125.GA18218@xxxxxxxxxxxxx> <20090224184252.GA28007@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
Christoph Hellwig wrote:
> On Sun, Feb 15, 2009 at 03:21:25PM -0500, Christoph Hellwig wrote:
>> currently Makepkgs generats the source tarball as
>> package-version.src.tar.gz, which is not what we used for recent
>> releases and not what most other open source packages do.  I'd like to
>> change it to package-version.tar.gz, but that currently collides with
>> the binary tar packages.
>>
>> Does anyone still need those binary tar packages?  If yes we should
>> rename them, too or otherwise just remove them.
> 
> This would be the easiest way, renaming the binary packages to
> xfsprogs-$ver.bin.tar.gz and the source to the expected
> xfsprogs-$ver.tar.gz.  Same patch would also go into xfsdump and dmapi.
> 

Yes, this looks good.  it always bugged me the way it was ;)

Missed this for review based on no [PATCH] ;)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

(same for the other packages as well)

> Index: xfsprogs-dev/build/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/Makefile  2009-02-24 19:39:37.259153164 +0100
> +++ xfsprogs-dev/build/Makefile       2009-02-24 19:39:58.817035065 +0100
> @@ -6,7 +6,7 @@ TOPDIR = ..
>  include $(TOPDIR)/include/builddefs
>  
>  MANIFEST=src-manifest
> -SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
> +SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>  
>  LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
>  
> Index: xfsprogs-dev/build/tar/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/tar/Makefile      2009-02-24 19:40:08.459152818 
> +0100
> +++ xfsprogs-dev/build/tar/Makefile   2009-02-24 19:40:13.721029934 +0100
> @@ -5,7 +5,7 @@
>  TOPDIR = ../..
>  include $(TOPDIR)/include/builddefs
>  
> -BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> +BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
>  LDIRT = *.gz
>  
>  default install install-dev install-lib:
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>