| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/5] [XFS] Remove xfs_flush_space |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 16 Mar 2009 05:15:19 -0400 |
| Cc: | xfs@xxxxxxxxxxx, mpatocka@xxxxxxxxxx |
| In-reply-to: | <1237116707-25793-6-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1237116707-25793-1-git-send-email-david@xxxxxxxxxxxxx> <1237116707-25793-6-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Sun, Mar 15, 2009 at 10:31:47PM +1100, Dave Chinner wrote: > The only thing we need to do now when we get an ENOSPC condition during > delayed > allocation reservation is flush all the other inodes with delalloc blocks on > them and retry without EOF preallocation. Remove the unneeded mess that is > xfs_flush_space() and just call xfs_flush_inodes() directly from > xfs_iomap_write_delay(). > > Also, change the location of the retry label to avoid trying to do EOF > preallocation because we don't want to do that at ENOSPC. This enables us to > remove the BMAPI_SYNC flag as it is no longer used. Looks good. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] [XFS] Flush delayed allcoation blocks on ENOSPC in create, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] XFS: Pagecache usage optimization on XFS, Christoph Hellwig |
| Previous by Thread: | [PATCH 5/5] [XFS] Remove xfs_flush_space, Dave Chinner |
| Next by Thread: | [PATCH 2/5] [XFS] Make inode flush at ENOSPC synchronous, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |