[Top] [All Lists]

Re: [PATCH 1/3] [XFSQA] Reduce the number of processes forked

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] [XFSQA] Reduce the number of processes forked
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 16 Mar 2009 02:23:13 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1237114181-18431-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1237114181-18431-1-git-send-email-david@xxxxxxxxxxxxx> <1237114181-18431-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Mar 15, 2009 at 09:49:39PM +1100, Dave Chinner wrote:
> One of the big cpu time consumers when running xfsqa on UML
> is forking of new processes. when looping lots of times,
> using 'expr' to calculate the loop counter increment means
> we fork at least once every loop. using shell builtins means
> that we don't fork and many tests run substantially faster.
> Some tests are even runnable with this modification. e.g. 110
> went from taking 4500s to run down to 9s with the loop iterators
> changed to avoid forking.

Looks good.

Care to see if any tests should be added to the quick group after this?
The above 110 sounds like a candidate for that.

<Prev in Thread] Current Thread [Next in Thread>