[Top] [All Lists]

Re: [PATCH 2/2] [XFS] Fix double free of inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] [XFS] Fix double free of inode
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 15 Mar 2009 11:13:41 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1237116342-25701-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1237116342-25701-1-git-send-email-david@xxxxxxxxxxxxx> <1237116342-25701-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Mar 15, 2009 at 10:25:42PM +1100, Dave Chinner wrote:
> If we fail to initialise the VFS inode in inode_init_always(),
> it will call ->delete_inode internally resulting in the inode being
> freed. Hence we need to delay the call to inode_init_always()
> until after the XFS inode is sufficient set up to handle a
> call to ->delete_inode, and then if that fails do not touch
> the inode again at all as it has been freed.

Looks good, but the changelog should mention the setting of the
I_NEW bit, too.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

I suspect this should go into 2.6.29-stable after some testing, too.

<Prev in Thread] Current Thread [Next in Thread>