xfs
[Top] [All Lists]

Re: xfs: use generic Posix ACL code

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs: use generic Posix ACL code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 15 Mar 2009 19:18:56 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090304173008.GA32471@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090220205117.GA7943@xxxxxxxxxxxxx> <20090304173008.GA32471@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Mar 04, 2009 at 12:30:08PM -0500, Christoph Hellwig wrote:
> On Fri, Feb 20, 2009 at 03:51:17PM -0500, Christoph Hellwig wrote:
> > This patch rips out the XFS ACL handling code and uses the generic
> > fs/posix_acl.c code instead.  The ondisk format is of course left
> > unchanged.
> > 
> > This also introduces the same ACL caching all other Linux filesystems do
> > by adding pointers to the acl and default acl in struct xfs_inode.
> 
> FYI: there was one hunk that slipped into another patch so that it
> was missing in this one.  Correct one below:
> 
> 
> This patch rips out the XFS ACL handling code and uses the generic
> fs/posix_acl.c code instead.  The ondisk format is of course left
> unchanged.
> 
> This also introduces the same ACL caching all other Linux filesystems do
> by adding pointers to the acl and default acl in struct xfs_inode.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I haven't done an in-depth review of this, but i can't find any
glaring problems while reading over the diff. So, in the interests of
moving this forward, you can add a:

Acked-by: Dave Chinner <david@xxxxxxxxxxxxx>

to this. I think at this point it probably should be pushed into the
dev tree and aimed at 2.6.31....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>