xfs
[Top] [All Lists]

Re: [PATCH 4/7] xfs: cleanup xlog_bread

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] xfs: cleanup xlog_bread
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 15 Mar 2009 18:53:56 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090220085207.663702000@xxxxxxxxxxxxxxxxxxxxxx> <20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> Most callers of xlog_bread need to call xlog_align to get the actual offset.
> Consolidate that call into the main xlog_bread and provide a _xlog_bread
> for those few that don't want the actual offset.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

.....

>   * nbblks should be uint, but oh well.  Just want to catch that 32-bit 
> length.
>   */
> -int
> -xlog_bread(
> +STATIC int
> +_xlog_bread(
>       xlog_t          *log,
>       xfs_daddr_t     blk_no,
>       int             nbblks,
> @@ -137,6 +155,24 @@ xlog_bread(
>       return error;
>  }

xlog_bread_noalign().

Otherwise looks good. Consider it:

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 4/7] xfs: cleanup xlog_bread, Dave Chinner <=