[Top] [All Lists]

Re: [PATCH 3/7] xfs: cleanup xlog_recover_do_trans

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/7] xfs: cleanup xlog_recover_do_trans
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 15 Mar 2009 18:50:20 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090220085229.204188000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090220085207.663702000@xxxxxxxxxxxxxxxxxxxxxx> <20090220085229.204188000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Feb 20, 2009 at 03:52:10AM -0500, Christoph Hellwig wrote:
> Change the big if-elsif-else block handling the different item types
> into a more natural switch, remove assignments in conditionals and
> remove an out of place comment from centuries ago on IRIX.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 3/7] xfs: cleanup xlog_recover_do_trans, Dave Chinner <=