| To: | Felix Blyakher <felixb@xxxxxxx> |
|---|---|
| Subject: | Re: next-20090220: XFS: inconsistent lock state |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Mar 2009 12:02:48 -0500 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Alexander Beregalov <a.beregalov@xxxxxxxxx>, "linux-next@xxxxxxxxxxxxxxx" <linux-next@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <A277CB1C-4258-42EC-B1D9-F5CAAB962B42@xxxxxxx> |
| References: | <a4423d670902200952v5dc2fd91w3b54ab1db51a7fe2@xxxxxxxxxxxxxx> <20090224200740.GA9266@xxxxxxxxxxxxx> <49AD5401.30803@xxxxxxxxxxx> <A277CB1C-4258-42EC-B1D9-F5CAAB962B42@xxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Tue, Mar 03, 2009 at 10:57:07AM -0600, Felix Blyakher wrote:
> if (lock_flags) {
> if (!xfs_ilock_nowait(ip, lock_flags)) {
> ASSERT(0);
> error = EAGAIN;
> goto out_destroy;
> }
> }
>
> Or just keep the BUG(); , as it shouldn't happen (we hope).
Ok, let's keep the BUG for now and I'll throw in your error undwinding
fix. Will resend the series for 2.6.29 patches after QAing them.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: next-20090220: XFS: inconsistent lock state, Felix Blyakher |
|---|---|
| Next by Date: | [PATCH] xfs: validate quota log items during log recovery, Christoph Hellwig |
| Previous by Thread: | Re: next-20090220: XFS: inconsistent lock state, Felix Blyakher |
| Next by Thread: | Re: next-20090220: XFS: inconsistent lock state, Alexander Beregalov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |