[Top] [All Lists]

Re: [PATCH 4/7] xfs: cleanup xlog_bread

To: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] xfs: cleanup xlog_bread
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2009 09:40:48 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20090222224841.GW13088@xxxxxxxxxxxxxx>
References: <20090220085207.663702000@xxxxxxxxxxxxxxxxxxxxxx> <20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx> <20090222224841.GW13088@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Feb 22, 2009 at 05:48:41PM -0500, Josef 'Jeff' Sipek wrote:
> On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> > Most callers of xlog_bread need to call xlog_align to get the actual offset.
> > Consolidate that call into the main xlog_bread and provide a _xlog_bread
> > for those few that don't want the actual offset.
> Only one leading underscore? IOW, why not not __xlog_bread? (That's
> definitely more Linux-like.)

In that deep down xfs code a single underscore is the more common idiom.
Of course a descriptive name might be even better :)

<Prev in Thread] Current Thread [Next in Thread>