Re: [PATCH 4/7] xfs: cleanup xlog_bread

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Sun, Feb 22, 2009 at 05:48:41PM -0500, Josef 'Jeff' Sipek wrote:
> On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> > Most callers of xlog_bread need to call xlog_align to get the actual offset.
> > Consolidate that call into the main xlog_bread and provide a _xlog_bread
> > for those few that don't want the actual offset.
> 
> Only one leading underscore? IOW, why not not __xlog_bread? (That's
> definitely more Linux-like.)

In that deep down xfs code a single underscore is the more common idiom.
Of course a descriptive name might be even better :)