xfs
[Top] [All Lists]

[patch] fix parallel build failures in xfsprogs-3.0.0

To: "xfs-oss" <xfs@xxxxxxxxxxx>
Subject: [patch] fix parallel build failures in xfsprogs-3.0.0
From: Mike Frysinger <vapier@xxxxxxxxxx>
Date: Tue, 24 Feb 2009 00:10:24 -0500
Organization: wh0rd.org
User-agent: KMail/1.11.0 (Linux/2.6.28; KDE/4.2.0; x86_64; ; )
i noticed that xfsprogs-3.0.0 sometimes fails to build in parallel with an 
error about fsr not being able to find libhandle.  looking at the top level 
Makefile shows the obvious missing depend (fsr: libhandle).  playing around a 
bit found a few more not so obvious missing depends on the include subdir, so 
i fixed that too.
-mike
http://bugs.gentoo.org/260005

--- a/Makefile
+++ b/Makefile
@@ -15,11 +15,11 @@
 LDIRT = config.log .dep config.status config.cache confdefs.h conftest* \
        Logs/* built .census install.* install-dev.* *.gz
 
-LIB_SUBDIRS = include libxfs libxlog libxcmd libhandle libdisk
+LIB_SUBDIRS = libxfs libxlog libxcmd libhandle libdisk
 TOOL_SUBDIRS = copy db estimate fsck fsr growfs io logprint mkfs quota \
                mdrestore repair rtcp m4 man doc po debian build
 
-SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS)
+SUBDIRS = include $(LIB_SUBDIRS) $(TOOL_SUBDIRS)
 
 default: include/builddefs include/platform_defs.h
 ifeq ($(HAVE_BUILDDEFS), no)
@@ -29,9 +29,10 @@
 endif
 
 # tool/lib dependencies
-libxcmd: include
+$(LIB_SUBDIRS) $(TOOL_SUBDIRS): include
 copy mdrestore: libxfs
 db logprint: libxfs libxlog
+fsr: libhandle
 growfs: libxfs libxcmd
 io: libxcmd libhandle
 mkfs: libxfs libdisk

Attachment: signature.asc
Description: This is a digitally signed message part.

<Prev in Thread] Current Thread [Next in Thread>