Re: [PATCH 4/7] xfs: cleanup xlog

xfs

Re: [PATCH 4/7] xfs: cleanup xlog_bread

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/7] xfs: cleanup xlog_bread
From:	"Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date:	Sun, 22 Feb 2009 17:48:41 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20090220085207.663702000@xxxxxxxxxxxxxxxxxxxxxx> <20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> Most callers of xlog_bread need to call xlog_align to get the actual offset.
> Consolidate that call into the main xlog_bread and provide a _xlog_bread
> for those few that don't want the actual offset.

Only one leading underscore? IOW, why not not __xlog_bread? (That's
definitely more Linux-like.)

Josef 'Jeff' Sipek.

-- 
The box said "Windows XP or better required". So I installed Linux.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/7] a couple more random cleanups for 2.6.30, Christoph Hellwig [PATCH 2/7] xfs: remove another leftover of the old inode log item format, Christoph Hellwig [PATCH 1/7] xfs: cleanup log unmount handling, Christoph Hellwig [PATCH 6/7] xfs: kill VN_BAD, Christoph Hellwig [PATCH 4/7] xfs: cleanup xlog_bread, Christoph Hellwig Re: [PATCH 4/7] xfs: cleanup xlog_bread, Josef 'Jeff' Sipek <= Re: [PATCH 4/7] xfs: cleanup xlog_bread, Christoph Hellwig [PATCH 7/7] xfs: factor out code to find the longest free extent in the AG, Christoph Hellwig [PATCH 3/7] xfs: cleanup xlog_recover_do_trans, Christoph Hellwig *[PATCH 5/7] xfs: kill vn_atime_ helpers.*, Christoph Hellwig*

Previous by Date:	xfsprogs/xfsdump release process, Mike Frysinger
Next by Date:	UT Webmail internet support group, Mark Lemon
Previous by Thread:	[PATCH 4/7] xfs: cleanup xlog_bread, Christoph Hellwig
Next by Thread:	Re: [PATCH 4/7] xfs: cleanup xlog_bread, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]