[Top] [All Lists]

Re: [PATCH 4/7] xfs: cleanup xlog_bread

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] xfs: cleanup xlog_bread
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Sun, 22 Feb 2009 17:48:41 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20090220085207.663702000@xxxxxxxxxxxxxxxxxxxxxx> <20090220085229.488121000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Feb 20, 2009 at 03:52:11AM -0500, Christoph Hellwig wrote:
> Most callers of xlog_bread need to call xlog_align to get the actual offset.
> Consolidate that call into the main xlog_bread and provide a _xlog_bread
> for those few that don't want the actual offset.

Only one leading underscore? IOW, why not not __xlog_bread? (That's
definitely more Linux-like.)

Josef 'Jeff' Sipek.

The box said "Windows XP or better required". So I installed Linux.

<Prev in Thread] Current Thread [Next in Thread>