xfs
[Top] [All Lists]

[PATCH 5/7] xfs: kill vn_atime_* helpers.

To: xfs@xxxxxxxxxxx
Subject: [PATCH 5/7] xfs: kill vn_atime_* helpers.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 20 Feb 2009 03:52:12 -0500
References: <20090220085207.663702000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.47-1
Two out of three are unused already, and the third is better done open-coded
with a comment describing what's going on here.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs/fs/xfs/linux-2.6/xfs_vnode.h
===================================================================
--- xfs.orig/fs/xfs/linux-2.6/xfs_vnode.h       2009-02-03 17:38:26.016436576 
+0100
+++ xfs/fs/xfs/linux-2.6/xfs_vnode.h    2009-02-03 17:40:13.809477409 +0100
@@ -58,25 +58,6 @@ static inline int VN_BAD(struct inode *v
 }
 
 /*
- * Extracting atime values in various formats
- */
-static inline void vn_atime_to_bstime(struct inode *vp, xfs_bstime_t *bs_atime)
-{
-       bs_atime->tv_sec = vp->i_atime.tv_sec;
-       bs_atime->tv_nsec = vp->i_atime.tv_nsec;
-}
-
-static inline void vn_atime_to_timespec(struct inode *vp, struct timespec *ts)
-{
-       *ts = vp->i_atime;
-}
-
-static inline void vn_atime_to_time_t(struct inode *vp, time_t *tt)
-{
-       *tt = vp->i_atime.tv_sec;
-}
-
-/*
  * Some useful predicates.
  */
 #define VN_MAPPED(vp)  mapping_mapped(vp->i_mapping)
Index: xfs/fs/xfs/xfs_itable.c
===================================================================
--- xfs.orig/fs/xfs/xfs_itable.c        2009-02-03 17:38:26.035436548 +0100
+++ xfs/fs/xfs/xfs_itable.c     2009-02-03 17:39:41.954562280 +0100
@@ -83,7 +83,12 @@ xfs_bulkstat_one_iget(
        buf->bs_uid = dic->di_uid;
        buf->bs_gid = dic->di_gid;
        buf->bs_size = dic->di_size;
-       vn_atime_to_bstime(VFS_I(ip), &buf->bs_atime);
+       /*
+        * We are reading the atime from the Linux inode because the
+        * dinode might not be uptodate.
+        */
+       buf->bs_atime.tv_sec = VFS_I(ip)->i_atime.tv_sec;
+       buf->bs_atime.tv_nsec = VFS_I(ip)->i_atime.tv_nsec;
        buf->bs_mtime.tv_sec = dic->di_mtime.t_sec;
        buf->bs_mtime.tv_nsec = dic->di_mtime.t_nsec;
        buf->bs_ctime.tv_sec = dic->di_ctime.t_sec;

<Prev in Thread] Current Thread [Next in Thread>