xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: fix system() error reporting

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: fix system() error reporting
From: Timothy Shimmin <timothy.shimmin@xxxxxxxxx>
Date: Wed, 18 Feb 2009 17:38:48 +1100
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=lxZ1m7dd/r1G8TT4htBkUuQEMIhQTS9KEQuebXAN3Mk=; b=o0YrPrKhDquxl4bpZVPDINEIOZzqaMHj7O5nlg5FrWxL7kd6taLooR8zHtdL5z50VP o8RPrqVFaIv6NteeIfMjKo90K+L9eiMyXicZ3qcGz1Rq63Y8zhC5UW45wZJxZuU/66p0 PMLY6iwQFbVBJQfgrzaEfkp+XBwP1901OFy/g=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=kqKOKlIiqPrhhKerYdnPMcXBulqvszATsbZBGjqapL0/8B+lKPWjwZapdzdOPZ1pRR 7wzYRb7g6MKEjmg9l0Xilogvr19QLthNBTEilHsfzG2YSE5aGZlX72BvAgk/Kp4P/uF6 aXSzXAHAaQv/JQqHcBz0z8coSixMyOhVGk/Ug=
In-reply-to: <20090217093824.GB15620@xxxxxxxxxxxxx>
References: <20090216102845.GA6835@xxxxxxxxxxxxx> <d38e348a0902161608r466a2582pfd5fd75e17a66f12@xxxxxxxxxxxxxx> <20090217093824.GB15620@xxxxxxxxxxxxx>
On Tue, Feb 17, 2009 at 8:38 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
On Tue, Feb 17, 2009 at 11:08:33AM +1100, Timothy Shimmin wrote:
> Hi Christoph,
>
> Looks reasonable.
> Though, in the case of returning -1, it might be more interesting
> to know the value of errno ? (I presume errno would be set in that case).

From looking at the manpage and the glibc implementation it seem like
system does not actually set errno.


Fair enough.

Yeah, it didn't seem clear in the man page and
I thought it might make a call to fork, waitpid etc which might set an errno.

Cheers,
Tim.
<Prev in Thread] Current Thread [Next in Thread>