xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: fix system() error reporting

To: Timothy Shimmin <timothy.shimmin@xxxxxxxxx>
Subject: Re: [PATCH] xfsdump: fix system() error reporting
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2009 04:38:24 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <d38e348a0902161608r466a2582pfd5fd75e17a66f12@xxxxxxxxxxxxxx>
References: <20090216102845.GA6835@xxxxxxxxxxxxx> <d38e348a0902161608r466a2582pfd5fd75e17a66f12@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Feb 17, 2009 at 11:08:33AM +1100, Timothy Shimmin wrote:
> Hi Christoph,
> 
> Looks reasonable.
> Though, in the case of returning -1, it might be more interesting
> to know the value of errno ? (I presume errno would be set in that case).

>From looking at the manpage and the glibc implementation it seem like
system does not actually set errno.

<Prev in Thread] Current Thread [Next in Thread>