xfs
[Top] [All Lists]

Re: [PATCH] Fix off by one error in page_region_mask()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Fix off by one error in page_region_mask()
From: Felix Blyakher <felixb@xxxxxxx>
Date: Mon, 16 Feb 2009 11:14:59 -0600
Cc: Lachlan McIlroy <lachlan@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090215191614.GA862@xxxxxxxxxxxxx>
References: <49378B60.1060603@xxxxxxx> <20081222085354.GC24795@xxxxxxxxxxxxx> <49502F91.4050406@xxxxxxx> <49742371.2000806@xxxxxxx> <20090122222539.GA9643@xxxxxxxxxxxxx> <20090215191614.GA862@xxxxxxxxxxxxx>
On Feb 15, 2009, at 1:16 PM, Christoph Hellwig wrote:

On Thu, Jan 22, 2009 at 05:25:39PM -0500, Christoph Hellwig wrote:
On Mon, Jan 19, 2009 at 05:53:37PM +1100, Lachlan McIlroy wrote:
Lachlan McIlroy wrote:
Christoph Hellwig wrote:
Did you guys come to a conclusion in your discussions?

No conclusion, well nothing that resulted in an ack.

Was anyone okay with this fix?

I think it's okay to go.  It fixes the one off so it's go.

The code is still a very hard to understand mess, but that's not what
the patch was supposed to fix..

Any reason this isn't in yet?

Sorry, I was holding it. I had some doubts with the mod, but
couldn't materialize them into a real argument.
I guess, I just check it in (I saw your ACK some time ago, Christoph),
and deal with anything popping up in this area later.

Felix

<Prev in Thread] Current Thread [Next in Thread>