xfs
[Top] [All Lists]

[PATCH] test 199: test features2 fixup for the regular case, too

To: xfs@xxxxxxxxxxx
Subject: [PATCH] test 199: test features2 fixup for the regular case, too
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 14 Feb 2009 11:40:24 -0500
User-agent: Mutt/1.5.18 (2008-05-17)
Eric Sandeen noted that we should not only test the mount ro first, then
remount rw case in 199 but also the regular mount rw case.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfstests-dev/199
===================================================================
--- xfstests-dev.orig/199       2009-02-14 15:08:08.000000000 +0000
+++ xfstests-dev/199    2009-02-14 15:10:53.000000000 +0000
@@ -1,8 +1,10 @@
 #! /bin/sh
 # FS QA Test No. 199
 #
-# Check that a filesystem first mounted read-only and then remounted
-# performs the features2 fixup properly.
+# Check that the features2 localtion fixups work correctly.  We check both
+# a regualar read-write mount of a filesystem and the case where the
+# filesystem is first mounted read-only and then later remounted read-write,
+# which is the usual case for the root filesystem.
 #
 #-----------------------------------------------------------------------
 # Copyright (c) 2008 Christoph Hellwig.
@@ -51,8 +53,20 @@
 echo "Clearing features2:"
 xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
 
+_scratch_mount
+umount $SCRATCH_MNT
+echo "Features 2 after mount rw:"
+xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2'
+
+#
+# Clear the normal flags again for the second rount.
+#
+echo "Clearing features2:"
+xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
+
 #
 # And print the flags after a mount ro and remount rw
+#
 _scratch_mount -o ro
 _scratch_mount -o remount,rw
 umount $SCRATCH_MNT
Index: xfstests-dev/199.out
===================================================================
--- xfstests-dev.orig/199.out   2009-02-14 15:11:18.000000000 +0000
+++ xfstests-dev/199.out        2009-02-14 15:11:26.000000000 +0000
@@ -4,6 +4,10 @@
 bad_features2 = 0x8
 Clearing features2:
 features2 = 0
+Features 2 after mount rw:
+features2 = 0x8
+Clearing features2:
+features2 = 0
 Features 2 after mount ro and remount rw:
 features2 = 0x8
 *** done

<Prev in Thread] Current Thread [Next in Thread>