xfs
[Top] [All Lists]

Re: [patch 2/5] [PATCH] acl: various improvements for test/run

To: Andreas Gruenbacher <agruen@xxxxxxx>
Subject: Re: [patch 2/5] [PATCH] acl: various improvements for test/run
From: Greg Banks <gnb@xxxxxxxxxxxxxxxxx>
Date: Mon, 09 Feb 2009 15:29:28 +1100
Cc: xfs@xxxxxxxxxxx, tes@xxxxxxx, Brandon Philips <bphilips@xxxxxxx>, brandon@xxxxxxxx
In-reply-to: <200902090229.47550.agruen@xxxxxxx>
Organization: File Serving Technologies ; Silicon Graphics Inc.
References: <20090108015355.613058570@xxxxxxxx> <20090108015418.699729152@xxxxxxxx> <200902090229.47550.agruen@xxxxxxx>
User-agent: Thunderbird 1.5.0.12 (X11/20060911)
Andreas Gruenbacher wrote:
> Brandon,
>
> the version of the run script in the attr and acl packages is somewhat dated; 
> I have made a few improvements since. I'll move this out of {acl,attr}/test 
> and put the latest version into the libmisc/ directory.
>
> Note that I recently rewrote the run script from scratch. Unlike the old 
> version, the new one runs the whole script inside the same shell. There are 
> still a few problems to be solved; most importantly, user switching doesn't 
> work, yet.
I hope you get that feature done soon, and look forward to reviewing
it.  Let me just be Captain Obvious and say that user switching is a
critical feature for code used to drive ACL tests ;-)

>  Eventually I want to replace the old version, though.
>
>       http://savannah.nongnu.org/projects/shrun
>
>
>
>   
>> Add a | test line that is similar to > but is interpreted as a regular
>> expression.
>>     
>
> I have been using ">~" instead of "|" for that. I'm still not sure that 
> including regular expression matching was a good idea though, so shrun 
> doesn't have any of that yet. We'll se how things develop.
>
>
>   
Regexp matching is the kind of thing that sounds like it could be quite
useful, but it's a pain to implement.  When I wrote a Python interpreter
for the shrun language for use in Newpynfs, I didn't bother implementing
the regexp feature.

-- 
Greg Banks, P.Engineer, SGI Australian Software Group.
the brightly coloured sporks of revolution.
I don't speak for SGI.

<Prev in Thread] Current Thread [Next in Thread>