xfs
[Top] [All Lists]

Re: xfs_db: fix wrong sibling pointers offset for the bmbt attr block

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs_db: fix wrong sibling pointers offset for the bmbt attr block
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 9 Feb 2009 13:11:36 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090208211515.GB22118@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090208211515.GB22118@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Feb 08, 2009 at 04:15:15PM -0500, Christoph Hellwig wrote:
> The attr bmbt should use long, not short pointers.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfsprogs-dev/db/btblock.c
> ===================================================================
> --- xfsprogs-dev.orig/db/btblock.c    2009-02-08 22:13:05.225944103 +0100
> +++ xfsprogs-dev/db/btblock.c 2009-02-08 22:13:14.143944165 +0100
> @@ -227,8 +227,8 @@ const field_t     bmapbtd_flds[] = {
>       { "magic", FLDT_UINT32X, OI(OFF(magic)), C1, 0, TYP_NONE },
>       { "level", FLDT_UINT16D, OI(OFF(level)), C1, 0, TYP_NONE },
>       { "numrecs", FLDT_UINT16D, OI(OFF(numrecs)), C1, 0, TYP_NONE },
> -     { "leftsib", FLDT_DFSBNO, OI(OFF(u.s.bb_leftsib)), C1, 0, TYP_BMAPBTD },
> -     { "rightsib", FLDT_DFSBNO, OI(OFF(u.s.bb_rightsib)), C1, 0, TYP_BMAPBTD 
> },
> +     { "leftsib", FLDT_DFSBNO, OI(OFF(u.l.bb_leftsib)), C1, 0, TYP_BMAPBTD },
> +     { "rightsib", FLDT_DFSBNO, OI(OFF(u.l.bb_rightsib)), C1, 0, TYP_BMAPBTD 
> },
>       { "recs", FLDT_BMAPBTDREC, btblock_rec_offset, btblock_rec_count,
>         FLD_ARRAY|FLD_ABASE1|FLD_COUNT|FLD_OFFSET, TYP_NONE },
>       { "keys", FLDT_BMAPBTDKEY, btblock_key_offset, btblock_key_count,

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>


-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>