xfs
[Top] [All Lists]

Re: [patch 2/5] [PATCH] acl: various improvements for test/run

To: xfs@xxxxxxxxxxx
Subject: Re: [patch 2/5] [PATCH] acl: various improvements for test/run
From: Andreas Gruenbacher <agruen@xxxxxxx>
Date: Mon, 9 Feb 2009 02:29:47 +0100
Cc: brandon@xxxxxxxx, tes@xxxxxxx, Brandon Philips <bphilips@xxxxxxx>
In-reply-to: <20090108015418.699729152@xxxxxxxx>
Organization: SUSE Labs / Novell
References: <20090108015355.613058570@xxxxxxxx> <20090108015418.699729152@xxxxxxxx>
User-agent: KMail/1.9.9
Brandon,

the version of the run script in the attr and acl packages is somewhat dated; 
I have made a few improvements since. I'll move this out of {acl,attr}/test 
and put the latest version into the libmisc/ directory.

Note that I recently rewrote the run script from scratch. Unlike the old 
version, the new one runs the whole script inside the same shell. There are 
still a few problems to be solved; most importantly, user switching doesn't 
work, yet. Eventually I want to replace the old version, though.

        http://savannah.nongnu.org/projects/shrun


On Thursday, 8 January 2009 2:53:57 brandon@xxxxxxxx wrote:
> First move process_test to avoid a warning:
>
> main::process_test() called too early to check prototype at ./run line 47.
> main::process_test() called too early to check prototype at ./run line 60.

The new version had this fixed already.

> Create two ENV variables TUSER and TGROUP to get the user/group
> running the test.

Good idea. Added.

(Stuff like this will be obsolete with shrun.)

> Add a | test line that is similar to > but is interpreted as a regular
> expression.

I have been using ">~" instead of "|" for that. I'm still not sure that 
including regular expression matching was a good idea though, so shrun 
doesn't have any of that yet. We'll se how things develop.

Thanks,
Andreas

<Prev in Thread] Current Thread [Next in Thread>