Re: [PATCH 09/17] xfs: cleanup xfs_find_handle

[Felix Blyakher <felixb@xxxxxxx>]

On Feb 6, 2009, at 1:17 AM, Christoph Hellwig wrote:

> On Thu, Feb 05, 2009 at 11:20:22PM -0600, Felix Blyakher wrote:
> > Do we want to verify here that cmd is either XFS_IOC_PATH_TO_FSHANDLE
> > or XFS_IOC_PATH_TO_HANDLE ...
> It's called in a single place for just these three subcases, so having
> another verification here doesn't seem juseful.
Yes, I know it's called from xfs_file_ioctl() only, and only
with the those three commands, but I prefer the defensive code,
which would flag something unexpected rather then going the
wrong way.
Though, in this case, I'm not too much set on the "defensive"
side :)

Reviewed-by: Felix Blyakher <felixb@xxxxxxx>