xfs
[Top] [All Lists]

Re: [PATCH 09/17] xfs: cleanup xfs_find_handle

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 09/17] xfs: cleanup xfs_find_handle
From: Felix Blyakher <felixb@xxxxxxx>
Date: Fri, 6 Feb 2009 14:31:14 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090206071717.GA3295@xxxxxxxxxxxxx>
References: <20090126073136.384490000@xxxxxxxxxxxxxxxxxxxxxx> <20090126073202.277472000@xxxxxxxxxxxxxxxxxxxxxx> <F4717E19-7A7F-40CD-BAEB-7AE519E797D0@xxxxxxx> <20090206071717.GA3295@xxxxxxxxxxxxx>

On Feb 6, 2009, at 1:17 AM, Christoph Hellwig wrote:

On Thu, Feb 05, 2009 at 11:20:22PM -0600, Felix Blyakher wrote:
Do we want to verify here that cmd is either XFS_IOC_PATH_TO_FSHANDLE
or XFS_IOC_PATH_TO_HANDLE ...

It's called in a single place for just these three subcases, so having
another verification here doesn't seem juseful.

Yes, I know it's called from xfs_file_ioctl() only, and only
with the those three commands, but I prefer the defensive code,
which would flag something unexpected rather then going the
wrong way.
Though, in this case, I'm not too much set on the "defensive"
side :)

Reviewed-by: Felix Blyakher <felixb@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>