xfs
[Top] [All Lists]

Re: [PATCH 09/17] xfs: cleanup xfs_find_handle

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: [PATCH 09/17] xfs: cleanup xfs_find_handle
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 6 Feb 2009 02:17:17 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <F4717E19-7A7F-40CD-BAEB-7AE519E797D0@xxxxxxx>
References: <20090126073136.384490000@xxxxxxxxxxxxxxxxxxxxxx> <20090126073202.277472000@xxxxxxxxxxxxxxxxxxxxxx> <F4717E19-7A7F-40CD-BAEB-7AE519E797D0@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Feb 05, 2009 at 11:20:22PM -0600, Felix Blyakher wrote:
> Do we want to verify here that cmd is either XFS_IOC_PATH_TO_FSHANDLE
> or XFS_IOC_PATH_TO_HANDLE ...

It's called in a single place for just these three subcases, so having
another verification here doesn't seem juseful.

<Prev in Thread] Current Thread [Next in Thread>