xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Fix *FLAGS passing and dependencies.

To: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH] xfstests: Fix *FLAGS passing and dependencies.
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 02 Feb 2009 14:16:10 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1233565776-563-1-git-send-email-arekm@xxxxxxxx>
References: <1233565776-563-1-git-send-email-arekm@xxxxxxxx>
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Arkadiusz Miśkiewicz wrote:
> Pass *FLAGS in some targets.
> 
> Drop LIBHANDLE, LIBATTR and LIBACL from deps since there are in form
> "-llibrary".

ugh, weird.

> 
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>

Looks fine to me.  I'll merge it to the kernel.org repo.

-Eric

> ---
>  src/Makefile |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/Makefile b/src/Makefile
> index ad4c204..634e1b3 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -58,10 +58,10 @@ genhashnames: genhashnames.o
>  nametest: nametest.o $(LIBTEST)
>       $(LINKTEST) $(LIBTEST) $(LDLIBS)
>  
> -bstat: bstat.o $(LIBHANDLE)
> +bstat: bstat.o
>       $(LINKTEST) $(LIBHANDLE) $(LDLIBS)
>  
> -t_immutable: t_immutable.o $(LIBHANDLE) $(LIBACL)
> +t_immutable: t_immutable.o
>       $(LINKTEST) $(LIBACL) $(LIBHANDLE) $(LDLIBS)
>  
>  loggen:      loggen.o
> @@ -82,17 +82,17 @@ multi_open_unlink: multi_open_unlink.o
>  #scaleread: scaleread.o $(LDLIBS)
>  #    $(LINKTEST)
>  
> -acl_get: acl_get.o $(LIBACL) $(LIBATTR)
> +acl_get: acl_get.o
>       $(LINKTEST) $(LIBACL) $(LIBATTR) $(LDLIBS)
>  
> -dmiperf: dmiperf.o $(LIBATTR)
> +dmiperf: dmiperf.o
>       $(LINKTEST) $(LIBATTR) $(LDLIBS)
>  
>  preallo_rw_pattern_reader:
> -     $(CC) -DREAD iopat.c -o preallo_rw_pattern_reader
> +     $(CC) $(GCFLAGS) $(LDFLAGS) -DREAD iopat.c -o preallo_rw_pattern_reader
>  
>  preallo_rw_pattern_writer:
> -     $(CC) -DWRITE iopat.c -o preallo_rw_pattern_writer
> +     $(CC) $(GCFLAGS) $(LDFLAGS) -DWRITE iopat.c -o preallo_rw_pattern_writer
>  
>  ftrunc: ftrunc.o
>       $(LINKTEST)
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>