xfs
[Top] [All Lists]

Re: [PATCH 11/17] xfs: merge xfs_inode_flush into xfs_fs_write_inode

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/17] xfs: merge xfs_inode_flush into xfs_fs_write_inode
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 1 Feb 2009 11:54:26 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090126073202.588218000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090126073136.384490000@xxxxxxxxxxxxxxxxxxxxxx> <20090126073202.588218000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jan 26, 2009 at 02:31:47AM -0500, Christoph Hellwig wrote:
> Spliting the task for a VFS-induced inode flush into two functions doesn't

Splitting

> make any sense, so merge the two functions dealing with it.
.....
> +             error = xfs_iflush(ip, XFS_IFLUSH_ASYNC_NOBLOCK);
>       }
> -     error = xfs_inode_flush(ip, flags);
>  
> -out_error:
> + out_unlock:
> +     xfs_iunlock(ip, XFS_ILOCK_SHARED);
> + out:

Don't need spaces before the labels.

Otherwise looks OK.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>