xfs
[Top] [All Lists]

Re: [PATCH] remove remaining unused-but-installed headers

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] remove remaining unused-but-installed headers
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 29 Jan 2009 17:39:53 -0500
Cc: Nathan Scott <nscott@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20090129223700.GA3772@xxxxxxxxxxxxx>
References: <1233141843.4584.40.camel@xxxxxxxxxxxxxxxxxx> <20090129223700.GA3772@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
Christoph Hellwig wrote:
> On Wed, Jan 28, 2009 at 10:24:03PM +1100, Nathan Scott wrote:
>> diff --git a/include/Makefile b/include/Makefile
>> index 0403536..07076cc 100644
>> --- a/include/Makefile
>> +++ b/include/Makefile
>> @@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
>>      xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
>>      xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
>>      xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
>> -    xfs_trans.h xfs_trans_space.h xfs_types.h
>> +    xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
> 
> dfrag is not needed anymore because we moved fsr to xfsprogs.
> 
>> -    $(INSTALL) -m 755 -d $(DK_INC_DIR)
>> -    $(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
> 
> I think as some point libdisk was supposed to be a library others
> could use.  I don't mind if we make it private as it should be fold
> into the libvolume_id/libblkid successor in util-linux one day.

I don't know if there are plans to get the stripe size stuff into the
successor (what we have is kinda hacky) but maybe we should start that
conversation.

Keeping private should be fine, though.

-Eric

<Prev in Thread] Current Thread [Next in Thread>