On Wed, Jan 28, 2009 at 10:24:03PM +1100, Nathan Scott wrote:
> diff --git a/include/Makefile b/include/Makefile
> index 0403536..07076cc 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
> xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
> xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
> xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
> - xfs_trans.h xfs_trans_space.h xfs_types.h
> + xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
dfrag is not needed anymore because we moved fsr to xfsprogs.
> - $(INSTALL) -m 755 -d $(DK_INC_DIR)
> - $(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
I think as some point libdisk was supposed to be a library others
could use. I don't mind if we make it private as it should be fold
into the libvolume_id/libblkid successor in util-linux one day.
So all over this look good to me.
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|