xfs
[Top] [All Lists]

[PATCH] [LIBXCMD]: Move error messages to appropriate places.

To: xfs@xxxxxxxxxxx
Subject: [PATCH] [LIBXCMD]: Move error messages to appropriate places.
From: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
Date: Wed, 28 Jan 2009 19:24:11 +0100
Cc: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
Replace raw perror() with proper message in
fs_table_initialise_mounts().

Replace raw perror() with proper message and move it from
fs_mount_point_from_path() to fs_table_initialise_projects() where this
message has meaning.

Signed-off-by: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
---
 libxcmd/paths.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/libxcmd/paths.c b/libxcmd/paths.c
index facea06..6c36b79 100644
--- a/libxcmd/paths.c
+++ b/libxcmd/paths.c
@@ -248,7 +248,8 @@ fs_table_initialise_mounts(
        dir = fsname = fslog = fsrt = NULL;
 
        if ((count = getmntinfo(&stats, 0)) < 0) {
-               perror("getmntinfo");
+               fprintf(stderr, _("%s: getmntinfo() failed: %s\n"),
+                               progname, strerror(errno));
                return 0;
        }
 
@@ -298,7 +299,6 @@ fs_mount_point_from_path(
        struct stat64   s;
 
        if (stat64(dir, &s) < 0) {
-               perror(dir);
                return NULL;
        }
 
@@ -327,8 +327,11 @@ fs_table_initialise_projects(
        while ((path = getprpathent()) != NULL) {
                if (project && prid != path->pp_prid)
                        continue;
-               if ((fs = fs_mount_point_from_path(path->pp_pathname)) == NULL)
+               if ((fs = fs_mount_point_from_path(path->pp_pathname)) == NULL) 
{
+                       fprintf(stderr, _("%s: cannot find mount point for path 
`%s': %s\n"),
+                                       progname, path->pp_pathname, 
strerror(errno));
                        continue;
+               }
                found = 1;
                dir = strdup(path->pp_pathname);
                fsname = strdup(fs->fs_name);
-- 
1.6.1.1

<Prev in Thread] Current Thread [Next in Thread>