xfs
[Top] [All Lists]

Re: [PATCH 04/17] xfs: tiny cleanup for xfs_link

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/17] xfs: tiny cleanup for xfs_link
From: Felix Blyakher <felixb@xxxxxxx>
Date: Mon, 26 Jan 2009 16:23:02 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090126073200.781644000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20090126073136.384490000@xxxxxxxxxxxxxxxxxxxxxx> <20090126073200.781644000@xxxxxxxxxxxxxxxxxxxxxx>

On Jan 26, 2009, at 1:31 AM, Christoph Hellwig wrote:

The source and target inodes are guaranteed to never be the same by the VFS, so no need to check for that (and we would get into bad trouble later anyway if that were the case). Also clean up the error handling to use two gotos
instead of nested conditions.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Felix Blyakher <felixb@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>