Re: [PATCH 03/17] xfs: cleanup handling in xfs_swap

To:	xfs@xxxxxxxxxxx
Subject:	Re: [PATCH 03/17] xfs: cleanup handling in xfs_swap_extents
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 26 Jan 2009 02:55:52 -0500
In-reply-to:	<20090126073200.459094000@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20090126073136.384490000@xxxxxxxxxxxxxxxxxxxxxx> <20090126073200.459094000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Mon, Jan 26, 2009 at 02:31:39AM -0500, Christoph Hellwig wrote:
> Use multiple lables for proper error unwinding and get rid of some now
> superflous variables.

Sorry, should have been cleanup error handling and marked as beein
from Jeff.

Jeff, maybe you should just resend this yourself so that it doesn't
get messed up?  You can add my Tested-by flag as it passed xfsqa
on multiple platforms for me (although with the recent swapext flaw
I wonder if that actuall means anything :))

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 02/17] xfs: make sure to free the real-time inodes in the mount error path, (continued) [PATCH 02/17] xfs: make sure to free the real-time inodes in the mount error path, Christoph Hellwig Re: [PATCH 02/17] xfs: make sure to free the real-time inodes in the mount error path, Felix Blyakher Re: [PATCH 02/17] xfs: make sure to free the real-time inodes in the mount error path, Martin Steigerwald [PATCH 04/17] xfs: tiny cleanup for xfs_link, Christoph Hellwig Re: [PATCH 04/17] xfs: tiny cleanup for xfs_link, Felix Blyakher [PATCH 05/17] xfs: remove unused XFS_MOUNT_ILOCK/XFS_MOUNT_IUNLOCK, Christoph Hellwig Re: [PATCH 05/17] xfs: remove unused XFS_MOUNT_ILOCK/XFS_MOUNT_IUNLOCK, Felix Blyakher [PATCH 06/17] xfs: remove iclog calculation special cases, Christoph Hellwig [PATCH 07/17] xfs: remove superflous inobt macros, Christoph Hellwig [PATCH 03/17] xfs: cleanup handling in xfs_swap_extents, Christoph Hellwig Re: [PATCH 03/17] xfs: cleanup handling in xfs_swap_extents, Christoph Hellwig <= [PATCH] xfs: cleanup error handling in xfs_swap_extents, Josef 'Jeff' Sipek Re: [PATCH] xfs: cleanup error handling in xfs_swap_extents, Martin Steigerwald Re: [PATCH 03/17] xfs: cleanup handling in xfs_swap_extents, Felix Blyakher [PATCH 09/17] xfs: cleanup xfs_find_handle, Christoph Hellwig [PATCH 08/17] xfs: remove uchar_t/ushort_t/uint_t/ulong_t types, Christoph Hellwig [PATCH 13/17] xfs: get rid of indirections in the quotaops implementation, Christoph Hellwig [PATCH 17/17] xfs: sanitize qh_lock wrappers, Christoph Hellwig [PATCH 10/17] xfs: factor out attr fork reset handling, Christoph Hellwig Re: [PATCH 10/17] xfs: factor out attr fork reset handling, Felix Blyakher [PATCH 11/17] xfs: merge xfs_inode_flush into xfs_fs_write_inode, Christoph Hellwig

Previous by Date:	Re: [PATCH] don't reallocate sxp variable passed into xfs_swapext, Christoph Hellwig
Next by Date:	Re: Strange fragmentation in nearly empty filesystem, Carsten Oberscheid
Previous by Thread:	[PATCH 03/17] xfs: cleanup handling in xfs_swap_extents, Christoph Hellwig
Next by Thread:	[PATCH] xfs: cleanup error handling in xfs_swap_extents, Josef 'Jeff' Sipek
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 03/17] xfs: cleanup handling in xfs_swap_extents