xfs
[Top] [All Lists]

Re: [PATCH] don't reallocate sxp variable passed into xfs_swapext

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] don't reallocate sxp variable passed into xfs_swapext
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 26 Jan 2009 02:46:36 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, pm@xxxxxxxxxx
In-reply-to: <497D258C.1000908@xxxxxxxxxxx>
References: <497D258C.1000908@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Jan 25, 2009 at 08:53:00PM -0600, Eric Sandeen wrote:
> fixes kernel.org bugzilla 12538, xfs_fsr fails on 2.6.29-rc kernels
> 
> Regression caused by 743bb4650da9e2595d6cedd01c680b5b9398c74a
> 
> This was an embarrasing mistake, reallocating the sxp pointer passed
> in from the main ioctl switch.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx
> Reported-by: Paul Martin <pm@xxxxxxxxxx>
> Tested-by: Paul Martin <pm@xxxxxxxxxx>

Yikes.  Looks good to me, but any chance you could try cooking up a
xfsqa test that would hit this as our existing xfs_fsr test apparently
doesn't?


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>