[Top] [All Lists]

Re: [PATCH, needs new owner] xfs_repair memory optimization

To: Mark Goodwin <markgw@xxxxxxx>
Subject: Re: [PATCH, needs new owner] xfs_repair memory optimization
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 24 Jan 2009 09:23:31 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <497926DC.1030509@xxxxxxx>
References: <497926DC.1030509@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Jan 23, 2009 at 01:09:32PM +1100, Mark Goodwin wrote:
> A known limitation of xfs_repair is the large amount of memory it
> requires, depending on filesystem size and number of inodes, etc.
> The attached patch series, originally by Barry Bnaujok, is close to
> being finished but requires a new owner to do some final testing and
> polishing. It applies cleanly against top-of-tree xfsprogs-3.0.0

I did a quick look over it on the plane today and it looks quite nice
to me.

I guess there are no patch descriptions left anywhere?

Otherwise some of the patch might need some minor polishing, e.g.
the patch moving over from the radix tree to the btree leaves the
radix-tree implementation in, which gets removed in the next patch
which has otherwise unrelated changes.

The btree implementation btw worries me a little, I wonder if we need
a test harness to make sure it's correct for all corner cases.

<Prev in Thread] Current Thread [Next in Thread>