xfs
[Top] [All Lists]

[PATCH] [XFS] Warn on transaction in flight on read-only remount

To: xfs@xxxxxxxxxxx
Subject: [PATCH] [XFS] Warn on transaction in flight on read-only remount
From: Felix Blyakher <felixb@xxxxxxx>
Date: Fri, 23 Jan 2009 00:14:30 -0600
Cc: Felix Blyakher <felixb@xxxxxxx>
Till VFS can correctly support read-only remount without racing,
use WARN_ON instead of BUG_ON on detecting transaction in flight
after quiescing filesystem.

Signed-off-by: Felix Blyakher <felixb@xxxxxxx>
---
 fs/xfs/linux-2.6/xfs_sync.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index 2ed0353..a608e72 100644
--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -371,7 +371,11 @@ xfs_quiesce_attr(
        /* flush inodes and push all remaining buffers out to disk */
        xfs_quiesce_fs(mp);
 
-       ASSERT_ALWAYS(atomic_read(&mp->m_active_trans) == 0);
+       /*
+        * Just warn here till VFS can correctly support
+        * read-only remount without racing.
+        */
+       WARN_ON(atomic_read(&mp->m_active_trans) != 0);
 
        /* Push the superblock and write an unmount record */
        error = xfs_log_sbcount(mp, 1);
-- 
1.6.1

<Prev in Thread] Current Thread [Next in Thread>