Re: [PATCH] Re: Corrupted XFS log replay oops.

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Thu, Jan 22, 2009 at 11:06:48AM +0100, Eric Sesterhenn wrote:
> * Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote:
> > On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
> > >  xfs_buf_t *
> > >  xlog_get_bp(
> > >   xlog_t          *log,
> > > - int             num_bblks)
> > > + int             nbblks)
> > 
> > Any reason for reanming this variable?  That causes quite a bit of
> > churn.
> > 
> > >  {
> > > - ASSERT(num_bblks > 0);
> > > + if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> > > +         xlog_warn("XFS: Invalid block length (0x%x) given for buffer", 
> > > nbblks);
> > 
> > And doesn't prevent this line from needing a linebreak to stay under 80
> > characters :)
> > 
> > Except for these nitpicks it looks fine to me.
> 
> Using the image at http://www.cccmz.de/~snakebyte/xfs.254.img.bz2
> I was able to produce a pretty similar error with the patch applied

Different problem, obviously. ;)

I'll have a look at this later today....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx