xfs
[Top] [All Lists]

Re: [PATCH] Re: Corrupted XFS log replay oops.

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Re: Corrupted XFS log replay oops.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 23 Jan 2009 10:35:42 +1100
Cc: Nick Piggin <nickpiggin@xxxxxxxxxxxx>, Eric Sesterhenn <snakebyte@xxxxxx>, Pavel Machek <pavel@xxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, npiggin@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20090122061158.GA31104@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Nick Piggin <nickpiggin@xxxxxxxxxxxx>, Eric Sesterhenn <snakebyte@xxxxxx>, Pavel Machek <pavel@xxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, npiggin@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <20090113142147.GE16333@alice> <20090120173455.GC21339@alice> <20090121035703.GH10158@disturbed> <200901211503.07308.nickpiggin@xxxxxxxxxxxx> <20090122043747.GU10158@disturbed> <20090122061158.GA31104@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jan 22, 2009 at 01:11:58AM -0500, Christoph Hellwig wrote:
> On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
> >  xfs_buf_t *
> >  xlog_get_bp(
> >     xlog_t          *log,
> > -   int             num_bblks)
> > +   int             nbblks)
> 
> Any reason for reanming this variable?  That causes quite a bit of
> churn.

Just so it was the same variable name as the other I/O functions
around it. It's kind of strange to have one function use num_bblks
and another 4 or so related functions use nbblks....

> >  {
> > -   ASSERT(num_bblks > 0);
> > +   if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> > +           xlog_warn("XFS: Invalid block length (0x%x) given for buffer", 
> > nbblks);
> 
> And doesn't prevent this line from needing a linebreak to stay under 80
> characters :)

I'll respin it to fix this.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>