xfs
[Top] [All Lists]

Re: [PATCH] Re: Corrupted XFS log replay oops.

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Re: Corrupted XFS log replay oops.
From: Eric Sesterhenn <snakebyte@xxxxxx>
Date: Thu, 22 Jan 2009 09:35:06 +0100
Cc: Nick Piggin <nickpiggin@xxxxxxxxxxxx>, Pavel Machek <pavel@xxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, npiggin@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20090122061158.GA31104@xxxxxxxxxxxxx>
References: <20090113142147.GE16333@alice> <20090120173455.GC21339@alice> <20090121035703.GH10158@disturbed> <200901211503.07308.nickpiggin@xxxxxxxxxxxx> <20090122043747.GU10158@disturbed> <20090122061158.GA31104@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.16 (2007-06-09)
* Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote:
> On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
> >  xfs_buf_t *
> >  xlog_get_bp(
> >     xlog_t          *log,
> > -   int             num_bblks)
> > +   int             nbblks)
> 
> Any reason for reanming this variable?  That causes quite a bit of
> churn.
> 
> >  {
> > -   ASSERT(num_bblks > 0);
> > +   if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> > +           xlog_warn("XFS: Invalid block length (0x%x) given for buffer", 
> > nbblks);
> 
> And doesn't prevent this line from needing a linebreak to stay under 80
> characters :)
> 
> Except for these nitpicks it looks fine to me.

Just want to report that it fixes the issue for me. Thanks,
i will continue xfs testing.

Greetings, Eric

<Prev in Thread] Current Thread [Next in Thread>