[resending after fixing xfs mailing list on oss]
Just wanted to point out to discussion on this topic:
I merely took a suggestion from it, and put it in a patch.
On Jan 21, 2009, at 4:57 PM, Felix Blyakher wrote:
Till VFS can correctly support read-only remount without racing,
use WARN_ON instead of BUG_ON on detecting transaction in flight
after quiescing filesystem.
Signed-off-by: Felix Blyakher <felixb@xxxxxxx>
fs/xfs/linux-2.6/xfs_sync.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index 2ed0353..d8373ee 100644
@@ -371,7 +371,10 @@ xfs_quiesce_attr(
/* flush inodes and push all remaining buffers out to disk */
- ASSERT_ALWAYS(atomic_read(&mp->m_active_trans) == 0);
+ /* Just warn here till VFS can correctly support
+ * read-only remount without racing.
+ WARN_ON(atomic_read(&mp->m_active_trans) == 0);
/* Push the superblock and write an unmount record */
error = xfs_log_sbcount(mp, 1);