xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-11561-g55622c6
From: xfs@xxxxxxxxxxx
Date: Sun, 18 Jan 2009 22:06:00 -0600
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  2809f76 xfs: sanity check attr fork size
  7884bc8 xfs: fix bad_features2 fixups for the root filesystem
  98b8c7a xfs: add a lock class for group/project dquots
  5bb87a3 xfs: lockdep annotations for xfs_dqlock2
  a4edd1d xfs: add a separate lock class for the per-mount list of dquots
  178eae3 xfs: use mnt_want_write in compat_attrmulti ioctl
  d296d30 xfs: fix dentry aliasing issues in open_by_handle
      from  6c5200ce3c528a8f7695ee62f33ad84d8f84d444 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2809f76afce05a73e08120f455107912aa519647
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:04:16 2009 +0100

    xfs: sanity check attr fork size
    
    Recently we have quite a few kerneloops reports about dereferencing a NULL
    if_data in the attribute fork.  From looking over the code this can only
    happen if we pass a 0 size argument to xfs_iformat_local.  This implies some
    sort of corruption and in fact the only mailinglist report about this from
    earlier this year was after a powerfail presumably on a system with write
    cache and without barriers.
    
    Add a quick sanity check for the attr fork size in xfs_iformat to catch
    these early and without an oops.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit 7884bc8617e6b8afda8cb8853cf14abfd3148d5c
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:04:07 2009 +0100

    xfs: fix bad_features2 fixups for the root filesystem
    
    Currently the bad_features2 fixup and the alignment updates in the 
superblock
    are skipped if we mount a filesystem read-only.  But for the root filesystem
    the typical case is to mount read-only first and only later remount 
writeable
    so we'll never perform this update at all.  It's not a big problem but means
    the logs of people needing the fixup get spammed at every boot because they
    never happen on disk.
    
    Reported-by: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit 98b8c7a0c42acf0d6963dbb9aabe4a2e312aae12
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:03:25 2009 +0100

    xfs: add a lock class for group/project dquots
    
    We can have both a user and a group/project dquot locked at the same time,
    as long as the user dquot is locked first.  Tell lockdep about that fact
    by making the group/project dquots a different lock class.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit 5bb87a33b2cfb8e7ef3383718274094bdff266a3
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:03:19 2009 +0100

    xfs: lockdep annotations for xfs_dqlock2
    
    xfs_dqlock2 locks two xfs_dquots, which is fine as it always locks the
    dquot with the lower id first.  Use mutex_lock_nested to tell lockdep
    about this fact.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit a4edd1da20af79b2e92efeee3ca94831c8024d61
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:03:11 2009 +0100

    xfs: add a separate lock class for the per-mount list of dquots
    
    We can have both a a quota hash chain and the per-mount list locked at
    the same time.  But given that both use the same struct dqhash as list
    head we have to tell lockdep that they are different lock classes.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit 178eae342b34185ef7b11e62df2f74ba45daa56e
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:03:03 2009 +0100

    xfs: use mnt_want_write in compat_attrmulti ioctl
    
    The compat version of the attrmulti ioctl needs to ask for and then
    later release write access to the mount just like the native version,
    otherwise we could potentially write to read-only mounts.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

commit d296d30a9948e895bff005d92c38309e8bd30975
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Mon Jan 19 02:02:57 2009 +0100

    xfs: fix dentry aliasing issues in open_by_handle
    
    Open by handle just grabs an inode by handle and then creates itself
    a dentry for it.  While this works for regular files it is horribly
    broken for directories, where the VFS locking relies on the fact that
    there is only just one single dentry for a given inode, and that
    these are always connected to the root of the filesystem so that
    it's locking algorithms work (see Documentations/filesystems/Locking)
    
    Remove all the existing open by handle code and replace it with a small
    wrapper around the exportfs code which deals with all these issues.
    At the same time we also make the checks for a valid handle strict
    enough to reject all not perfectly well formed handles - given that
    we never hand out others that's okay and simplifies the code.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/Kconfig                 |    1 +
 fs/xfs/linux-2.6/xfs_ioctl.c   |  305 ++++++++++++++++++----------------------
 fs/xfs/linux-2.6/xfs_ioctl.h   |   15 ++-
 fs/xfs/linux-2.6/xfs_ioctl32.c |  184 ++++++++-----------------
 fs/xfs/linux-2.6/xfs_super.c   |   17 ++-
 fs/xfs/quota/xfs_dquot.c       |   36 ++++--
 fs/xfs/quota/xfs_dquot.h       |   10 ++
 fs/xfs/quota/xfs_qm.c          |    9 ++
 fs/xfs/xfs_inode.c             |   13 ++
 fs/xfs/xfs_mount.c             |   26 ++--
 fs/xfs/xfs_mount.h             |    3 +
 11 files changed, 294 insertions(+), 325 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-11561-g55622c6, xfs <=