xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 18 Jan 2009 13:28:00 -0600
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090118175842.GA15675@xxxxxxxxxxxxx>
References: <496E6FB4.8070300@xxxxxxxxxxx> <20090118175842.GA15675@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
Christoph Hellwig wrote:
> On Wed, Jan 14, 2009 at 05:05:24PM -0600, Eric Sandeen wrote:
>> allow xfs_freeze to freeze "foreign" filesystems
>>
>> Now that the freeze ioctl has been elevated to the VFS,
>> let's let xfs_io and xfs_freeze freeze other filesystems
>> as well - add the CMD_FOREIGN_OK flag to freeze & thaw.
>>
>> I think the worst that will happen on older kernels is that
>> the command will fail with ENOSYS or EINVAL....
> 
> Looks good to me, but I thikn you should also update the
> xfs_freeze manpage to mention that it works for non-XFS filesystems
> on 2.6.29 or newer kernels.

Ok, will do - thanks.

-Eric

<Prev in Thread] Current Thread [Next in Thread>