xfs
[Top] [All Lists]

Re: [PATCH] xfstests: only run 197 on 32-bit machines

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: only run 197 on 32-bit machines
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 18 Jan 2009 13:27:23 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090118171723.GA12645@xxxxxxxxxxxxx>
References: <496E9A84.2060304@xxxxxxxxxxx> <20090118171723.GA12645@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
Christoph Hellwig wrote:
> On Wed, Jan 14, 2009 at 08:08:04PM -0600, Eric Sandeen wrote:
>> Don't run test 197 on 64-bit machines
>>
>> If it always passes on 64 bits, this gives a false
>> sense of security.  Make it obvious.
> 
> I don't think it matters, but your patch looks correct and if it helps
> you in some way..
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 

thanks

I only wanted to put it in because I was looking at fedora, wanted to
test it against this bug, ran it, it passed, and *then* I remembered
that it'd only fail on 32-bit, and my test (on that hardware) wasn't
really valid.

-Eric

<Prev in Thread] Current Thread [Next in Thread>