Re: [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Jan 14, 2009 at 05:05:24PM -0600, Eric Sandeen wrote:
> allow xfs_freeze to freeze "foreign" filesystems
> 
> Now that the freeze ioctl has been elevated to the VFS,
> let's let xfs_io and xfs_freeze freeze other filesystems
> as well - add the CMD_FOREIGN_OK flag to freeze & thaw.
> 
> I think the worst that will happen on older kernels is that
> the command will fail with ENOSYS or EINVAL....

Looks good to me, but I thikn you should also update the
xfs_freeze manpage to mention that it works for non-XFS filesystems
on 2.6.29 or newer kernels.