xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: allow xfs_freeze to work on non-xfs filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 18 Jan 2009 12:58:42 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <496E6FB4.8070300@xxxxxxxxxxx>
References: <496E6FB4.8070300@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jan 14, 2009 at 05:05:24PM -0600, Eric Sandeen wrote:
> allow xfs_freeze to freeze "foreign" filesystems
> 
> Now that the freeze ioctl has been elevated to the VFS,
> let's let xfs_io and xfs_freeze freeze other filesystems
> as well - add the CMD_FOREIGN_OK flag to freeze & thaw.
> 
> I think the worst that will happen on older kernels is that
> the command will fail with ENOSYS or EINVAL....

Looks good to me, but I thikn you should also update the
xfs_freeze manpage to mention that it works for non-XFS filesystems
on 2.6.29 or newer kernels.

<Prev in Thread] Current Thread [Next in Thread>