xfs
[Top] [All Lists]

Re: [PATCH] xfstests: only run 197 on 32-bit machines

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: only run 197 on 32-bit machines
From: Felix Blyakher <felixb@xxxxxxx>
Date: Wed, 14 Jan 2009 23:14:22 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <496E9A84.2060304@xxxxxxxxxxx>
References: <496E9A84.2060304@xxxxxxxxxxx>

On Jan 14, 2009, at 8:08 PM, Eric Sandeen wrote:

Don't run test 197 on 64-bit machines

If it always passes on 64 bits, this gives a false
sense of security.  Make it obvious.

Sounds reasonable.


Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Signed-off-by: Felix Blyakher <felixb@xxxxxxx>

--

diff --git a/197 b/197
index 4c81941..f77bfa2 100644
--- a/197
+++ b/197
@@ -37,6 +37,10 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fs xfs
 _supported_os Linux

+bitsperlong=`src/feature -w`
+if [ "$bitsperlong" -ne 32 ]; then
+       _notrun "This test is only valid on 32 bit machines"
+fi

 mkdir $TEST_DIR/ttt
 for n in {1..168}; do


_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>