xfs
[Top] [All Lists]

Re: [PATCH 1/7] xfs: fix dentry aliasing issues in open_by_handle

To: Lachlan McIlroy <lachlan@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/7] xfs: fix dentry aliasing issues in open_by_handle
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Thu, 15 Jan 2009 09:50:18 +1100
In-reply-to: <20090114223737.GZ8071@disturbed>
Organization: SGI
References: <20090109221104.237540000@xxxxxxxxxxxxxxxxxxxxxx> <20090109221259.292773000@xxxxxxxxxxxxxxxxxxxxxx> <20090111233306.GH8071@disturbed> <20090112153934.GA28382@xxxxxxxxxxxxx> <496D8E10.4000501@xxxxxxx> <20090114223737.GZ8071@disturbed>
Reply-to: lachlan@xxxxxxx
User-agent: Thunderbird 2.0.0.19 (X11/20081209)
Dave Chinner wrote:
On Wed, Jan 14, 2009 at 06:02:40PM +1100, Lachlan McIlroy wrote:
Christoph,

When I build with this patch it fails with:

   CC      init/version.o
   LD      init/built-in.o
   LD      .tmp_vmlinux1
fs/built-in.o: In function `xfs_handle_to_dentry':
/home/lachlan/git/xfs-update/fs/xfs/linux-2.6/xfs_ioctl.c:211: undefined 
reference to `exportfs_decode_fh'
make: *** [.tmp_vmlinux1] Error 1

Given:

EXPORT_SYMBOL_GPL(exportfs_decode_fh);

Did you build with EXPORTFS support in your kernel?
Not explicitly.  I can't find a reference to it anywhere in my .config.


If not, then I think that fs/xfs/Kconfig needs to select EXPORTFS
when XFS is configured in (i.e. it's a new dependency).

Cheers,

Dave.

<Prev in Thread] Current Thread [Next in Thread>