xfs
[Top] [All Lists]

Re: [PATCH 6/7] xfs: fix bad_features2 fixups for the root filesystem

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/7] xfs: fix bad_features2 fixups for the root filesystem
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 12 Jan 2009 10:03:10 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090109221301.289471000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090109221104.237540000@xxxxxxxxxxxxxxxxxxxxxx> <20090109221301.289471000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Jan 09, 2009 at 05:11:10PM -0500, Christoph Hellwig wrote:
> Currently the bad_features2 fixup and the alignment updates in the superblock
> are skipped if we mount a filesystem read-only.  But for the root filesystem
> the typical case is to mount read-only first and only later remount writeable
> so we'll never perform this update at all.  It's not a big problem but means
> the logs of people needing the fixup get spammed at every boot because they
> never happen on disk.
> 
> Reported-by: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks sane.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>


-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>