xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 2.6.29

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [GIT PULL] XFS update for 2.6.29
From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Sun, 11 Jan 2009 11:38:13 +0100 (CET)
Cc: Lachlan McIlroy <lachlan@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Linux Kernel Development <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.64.0901021056360.14380@anakin>
References: <20081230030845.A4F0558AE206@xxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.64.0901011048090.14380@anakin> <20090101170329.GA17892@xxxxxxxxxxxxx> <Pine.LNX.4.64.0901021056360.14380@anakin>
Sender: geert@xxxxxxxxxxxxxx
On Fri, 2 Jan 2009, Geert Uytterhoeven wrote:
> On Thu, 1 Jan 2009, Christoph Hellwig wrote:
> > On Thu, Jan 01, 2009 at 10:50:52AM +0100, Geert Uytterhoeven wrote:
> > > | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock':
> > > | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to 
> > > limited range of data type
> > > | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to 
> > > limited range of data type
> > > 
> > > left/right = xfs_fsblock_t (32 or 64 bit), NULLDFSBNO = xfs_dfsbno_t (64 
> > > bit)
> > 
> > Hmm, can't reproduce it here with CONFIG_LBD=n on x86, but the following
> 
> x86-32 or -64?
> 
> It may also depend on the compiler version. I have gcc version 4.1.2 20061115
> (prerelease) (Debian 4.1.1-21).
> 
> > patch should fix it:
> 
> Yep, the warning is good.
                      ^^^^
                      gone

JFYI, the bug has entered Linus' tree. The fix hasn't.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>