xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add test 199, bad_features2 correction

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add test 199, bad_features2 correction
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2009 15:33:47 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4969053E.2060903@xxxxxxxxxxx>
References: <20090103205309.GB20346@xxxxxxxxxxxxx> <4969053E.2060903@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Jan 10, 2009 at 02:29:50PM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > Index: xfstests-dev/199
> > ===================================================================
> > --- /dev/null       1970-01-01 00:00:00.000000000 +0000
> > +++ xfstests-dev/199        2009-01-03 20:36:06.000000000 +0000
> > @@ -0,0 +1,65 @@
> > +#! /bin/sh
> > +# FS QA Test No. 199
> > +#
> > +# Check that a filesystem first mounted read-only and then remounted
> > +# performs the features2 fixup properly.
> 
> Seems fine.  Would it be worth adding a few more lines to also test that
> a simple rw mount (w/o going through ro first) also properly fixes it?

I was under the impression that we already tested that somewhere else,
but it seems like we don't.  Yes, I'll add it, that's a good one.

<Prev in Thread] Current Thread [Next in Thread>