xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: fix compile of xfs_btree_readahead_lblock on m68k

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfs: fix compile of xfs_btree_readahead_lblock on m68k
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2009 09:42:47 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090108184429.823470000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090108184222.244013000@xxxxxxxxxxxxxxxxxxxxxx> <20090108184429.823470000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jan 08, 2009 at 01:42:23PM -0500, Christoph Hellwig wrote:
> Change the left/right variables to the proper always 64bit xfs_dfsbo_t
> type because otherwise compilation fails for Geert on m68k without
> CONFIG_LBD:
> 
> | fs/xfs/xfs_btree.c: In function 'xfs_btree_readahead_lblock':
> | fs/xfs/xfs_btree.c:736: warning: comparison is always true due to limited 
> range of data type
> | fs/xfs/xfs_btree.c:741: warning: comparison is always true due to limited 
> range of data type
> 
> 
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>