[Top] [All Lists]

Re: [PATCH] define xfs_ino_t as unsigned long long

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] define xfs_ino_t as unsigned long long
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 6 Jan 2009 12:14:14 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090105193129.GA19909@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090105193129.GA19909@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jan 05, 2009 at 02:31:29PM -0500, Christoph Hellwig wrote:
> That way we can avoid ugly casts when printining it (like the ones
> that show up on powerpc with Linus' current tree).

Is that because ppc uses int-l64.h instead of int-64ll.h and so __64 gets
defined to an unsigned long on that platform?

Whatever the reason, it looks fine to me.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>